Skip to content
Snippets Groups Projects
  1. Oct 15, 2008
  2. Oct 14, 2008
  3. Oct 12, 2008
  4. Oct 08, 2008
  5. Sep 28, 2008
  6. Sep 24, 2008
  7. Sep 23, 2008
  8. Sep 11, 2008
  9. Sep 09, 2008
  10. Sep 03, 2008
  11. Sep 02, 2008
  12. Aug 28, 2008
  13. Aug 27, 2008
  14. Aug 21, 2008
  15. Aug 20, 2008
  16. Dec 20, 2007
  17. Nov 28, 2007
    • rsc's avatar
      fork minibug · c2258bf4
      rsc authored
      c2258bf4
    • rsc's avatar
      More complete lapic startup (thanks Silas) · 4f06ae0d
      rsc authored
      4f06ae0d
    • rsc's avatar
      · a6c4711a
      rsc authored
      bda[0xE] is a 16-bit segment number,
      not a real address.  So shift 4.
      
      Reported by Silas.
      
      Jim McKie says this code only matters
      on ancient EISA MP systems.
      a6c4711a
  18. Oct 20, 2007
  19. Oct 11, 2007
    • rsc's avatar
      · 949352af
      rsc authored
      Model verifying that wakeup really
      can be called after release without
      causing deadlock.
      949352af
  20. Oct 01, 2007
    • rsc's avatar
      · 943fd378
      rsc authored
      Incorporate new understanding of/with Intel SMP spec.
      
      Dropped cmpxchg in favor of xchg, to match lecture notes.
      
      Use xchg to release lock, for future protection and to
      keep gcc from acting clever.
      943fd378
  21. Sep 30, 2007
    • rsc's avatar
      · 9fd9f804
      rsc authored
      Re: why cpuid() in locking code?
      
      rtm wrote:
      > Why does acquire() call cpuid()? Why does release() call cpuid()?
      
      The cpuid in acquire is redundant with the cmpxchg, as you said.
      I have removed the cpuid from acquire.
      
      The cpuid in release is actually doing something important,
      but not on the hardware.  It keeps gcc from reordering the
      lock->locked assignment above the other two during optimization.
      (Not that current gcc -O2 would choose to do that, but it is allowed to.)
      I have replaced the cpuid in release with a "gcc barrier" that
      keeps gcc from moving things around but has no hardware effect.
      
      On a related note, I don't think the cpuid in mpmain is necessary,
      for the same reason that the cpuid wasn't needed in release.
      
      As to the question of whether
      
        acquire();
        x = protected;
        release();
      
      might read protected after release(), I still haven't convinced
      myself whether it can.  I'll put the cpuid back into release if
      we determine that it can.
      
      Russ
      9fd9f804
    • rsc's avatar
      tricks · c840f3ec
      rsc authored
      c840f3ec
Loading