Skip to content
Snippets Groups Projects

Slow Path Decide Bug Fix

Closed Michael Whittaker requested to merge majority_decide into master
  1. Mar 25, 2018
    • Michael Whittaker's avatar
      Switch to unique_ptr + consensus resends. · 4f0803c2
      Michael Whittaker authored
      Previously, timers were not using unique pointers, and some of the
      timers were being deleted twice I think (which is undefined behaviour).
      Now, all timers are wrapped up in unique pointers to avoid this.
      
      Also, consensus messages were not being resent. Now they are.
      4f0803c2
  2. Mar 06, 2018
    • Michael Whittaker's avatar
      Small typo fix. · 709d4511
      Michael Whittaker authored
      709d4511
    • Michael Whittaker's avatar
      Better debug logging in IR client & small bug fix. · 5c2b4f53
      Michael Whittaker authored
      The last commit introduced a bug in the IR client where we would
      transition into the slow path multiple times even after the request had
      already finished. This commit fixes that bug. It also improves some of
      the debug logs which I used to debug the bug.
      5c2b4f53
    • Michael Whittaker's avatar
      Fixed slow path lack of majority bug. · 3696c858
      Michael Whittaker authored
      Previously, the decide function was being called on the slow path
      whether or not we had a majority of responses from the replicas. Now, we
      only call decide and enter the finalize phase if we have a majority of
      replica responses.
      3696c858
  3. Mar 05, 2018
Loading