Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • tapir tapir
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • syslab
  • tapirtapir
  • Merge requests
  • !4

A couple of IR client fixes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Michael Whittaker requested to merge inconsistent_confirm into master Mar 05, 2018
  • Overview 1
  • Commits 1
  • Changes 2
  1. PendingRequest was used polymorphically but had a non-virtual destructor. Now, the destructor is virtual.
  2. HandleConfirm had what I thought was a bug (discussed in #13). Turns out it wasn't. I added a comment explaining why the code is not buggy.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: inconsistent_confirm