Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
shelf-inserts
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
make4all
createtivity
shelf-inserts
Commits
cea87b38
Unverified
Commit
cea87b38
authored
7 months ago
by
Jennifer Mankoff
Browse files
Options
Downloads
Patches
Plain Diff
fixed a bug with too many extra tabs over the slots
parent
ef190dbd
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
insert.py
+6
-3
6 additions, 3 deletions
insert.py
with
6 additions
and
3 deletions
insert.py
+
6
−
3
View file @
cea87b38
...
...
@@ -94,7 +94,6 @@ class ShelfInsert(Boxes):
Boxes
.
__init__
(
self
)
self
.
addSettingsArgs
(
OverhangSettings
,
finger
=
3.0
)
#self.addSettingsArgs(edges.FingerJointSettings, finger=3.0)
self
.
buildArgParser
(
"
sx
"
,
"
sy
"
,
"
h
"
,
"
outside
"
)
@property
...
...
@@ -154,7 +153,8 @@ class ShelfInsert(Boxes):
self
.
sx
=
self
.
adjustSize
(
self
.
sx
)
self
.
sy
=
self
.
adjustSize
(
self
.
sy
)
self
.
h
=
self
.
adjustSize
(
self
.
h
,
e2
=
False
)
# add an overhang to the front by changing the x width
x
=
self
.
Overhang_front_overhang
+
sum
(
self
.
sx
)
+
self
.
thickness
*
(
len
(
self
.
sx
)
-
1
)
y
=
sum
(
self
.
sy
)
+
self
.
thickness
*
(
len
(
self
.
sy
)
-
1
)
h
=
self
.
h
...
...
@@ -168,12 +168,15 @@ class ShelfInsert(Boxes):
######
for
i
in
range
(
len
(
self
.
sy
)
-
1
):
# this is a slotted edge with finger tabs on the slotted side ("f") and flat edges elsewhere ("e")
e
=
[
"
e
"
,
"
e
"
,
edges
.
SlottedEdge
(
self
,
self
.
sx
[::
-
1
],
"
f
"
,
slots
=
0.5
*
h
),
"
e
"
]
self
.
rectangularWall
(
x
,
h
,
e
,
move
=
"
up
"
,
label
=
"
x support
"
)
for
i
in
range
(
len
(
self
.
sx
)
-
1
):
# this is a slotted edge opposite the finger tabs (plus a gap where the slot is on the
# tabbed side)
e
=
[
edges
.
SlottedEdge
(
self
,
self
.
sy
,
"
e
"
,
slots
=
0.5
*
h
),
"
f
"
,
"
f
"
,
"
f
"
]
"
e
"
,
edges
.
SlottedEdge
(
self
,
self
.
sy
,
"
f
"
,
slots
=
0
*
h
),
"
e
"
]
self
.
rectangularWall
(
y
,
h
,
e
,
move
=
"
up
"
,
label
=
"
y support
"
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment