Skip to content
Snippets Groups Projects
Commit 3f077150 authored by Sean Busbey's avatar Sean Busbey
Browse files

[hbase10] Remove use of guava

- module previously had an undeclared dependency on guava
- removed VisibleForTesting in favor of a comment
- removed Preconditions.checkNotNull in favor of NPE through use

closes #1136
parent f886c1e7
No related branches found
No related tags found
No related merge requests found
...@@ -15,9 +15,6 @@ ...@@ -15,9 +15,6 @@
package com.yahoo.ycsb.db; package com.yahoo.ycsb.db;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Preconditions;
import com.yahoo.ycsb.ByteArrayByteIterator; import com.yahoo.ycsb.ByteArrayByteIterator;
import com.yahoo.ycsb.ByteIterator; import com.yahoo.ycsb.ByteIterator;
import com.yahoo.ycsb.DBException; import com.yahoo.ycsb.DBException;
...@@ -438,7 +435,7 @@ public class HBaseClient10 extends com.yahoo.ycsb.DB { ...@@ -438,7 +435,7 @@ public class HBaseClient10 extends com.yahoo.ycsb.DB {
try { try {
if (clientSideBuffering) { if (clientSideBuffering) {
Preconditions.checkNotNull(bufferedMutator); // removed Preconditions.checkNotNull, which throws NPE, in favor of NPE on next line
bufferedMutator.mutate(p); bufferedMutator.mutate(p);
} else { } else {
currentTable.put(p); currentTable.put(p);
...@@ -506,7 +503,7 @@ public class HBaseClient10 extends com.yahoo.ycsb.DB { ...@@ -506,7 +503,7 @@ public class HBaseClient10 extends com.yahoo.ycsb.DB {
d.setDurability(durability); d.setDurability(durability);
try { try {
if (clientSideBuffering) { if (clientSideBuffering) {
Preconditions.checkNotNull(bufferedMutator); // removed Preconditions.checkNotNull, which throws NPE, in favor of NPE on next line
bufferedMutator.mutate(d); bufferedMutator.mutate(d);
} else { } else {
currentTable.delete(d); currentTable.delete(d);
...@@ -521,7 +518,7 @@ public class HBaseClient10 extends com.yahoo.ycsb.DB { ...@@ -521,7 +518,7 @@ public class HBaseClient10 extends com.yahoo.ycsb.DB {
return Status.OK; return Status.OK;
} }
@VisibleForTesting // Only non-private for testing.
void setConfiguration(final Configuration newConfig) { void setConfiguration(final Configuration newConfig) {
this.config = newConfig; this.config = newConfig;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment