From f2eef8f01555d07255e17927578a8ec7134668ab Mon Sep 17 00:00:00 2001 From: Thomas Lopatic <thomas@lopatic.de> Date: Mon, 21 Sep 2015 13:50:28 +0200 Subject: [PATCH] Removed bad idea, which would have introduced a race condition. --- .../yahoo/ycsb/generator/AcknowledgedCounterGenerator.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/core/src/main/java/com/yahoo/ycsb/generator/AcknowledgedCounterGenerator.java b/core/src/main/java/com/yahoo/ycsb/generator/AcknowledgedCounterGenerator.java index c60936ae..443b47f5 100644 --- a/core/src/main/java/com/yahoo/ycsb/generator/AcknowledgedCounterGenerator.java +++ b/core/src/main/java/com/yahoo/ycsb/generator/AcknowledgedCounterGenerator.java @@ -40,9 +40,6 @@ public class AcknowledgedCounterGenerator extends CounterGenerator */ public void acknowledge(int value) { - // read volatile variable to see other threads' changes - limit = limit; - if (value > limit + WINDOW_SIZE) { throw new RuntimeException("Too many unacknowledged insertion keys."); } @@ -71,8 +68,5 @@ public class AcknowledgedCounterGenerator extends CounterGenerator lock.unlock(); } } - - // write volatile variable to make other threads see changes - limit = limit; } } -- GitLab