From b3dfd75831809aec13271aded51811c28c4852e1 Mon Sep 17 00:00:00 2001
From: Kirill Vlasov <kirill.vlasov@devfactory.com>
Date: Thu, 31 Dec 2015 16:26:16 +0500
Subject: [PATCH] [core dynamodb googledatastore infinispan] Fixing
pmd:UnnecessaryConstructor - Unnecessary constructor,
squid:EmptyStatementUsageCheck - Empty statements should be removed
---
core/src/main/java/com/yahoo/ycsb/StringByteIterator.java | 2 +-
.../main/java/com/yahoo/ycsb/measurements/Measurements.java | 2 +-
dynamodb/src/main/java/com/yahoo/ycsb/db/DynamoDBClient.java | 2 --
.../main/java/com/yahoo/ycsb/db/GoogleDatastoreClient.java | 2 --
.../main/java/com/yahoo/ycsb/db/InfinispanRemoteClient.java | 4 ----
5 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/core/src/main/java/com/yahoo/ycsb/StringByteIterator.java b/core/src/main/java/com/yahoo/ycsb/StringByteIterator.java
index 84465cba..4f00e7d1 100644
--- a/core/src/main/java/com/yahoo/ycsb/StringByteIterator.java
+++ b/core/src/main/java/com/yahoo/ycsb/StringByteIterator.java
@@ -62,7 +62,7 @@ public class StringByteIterator extends ByteIterator {
HashMap<String, String> ret = new HashMap<String,String>();
for(String s: m.keySet()) {
- ret.put(s, m.get(s).toString());;
+ ret.put(s, m.get(s).toString());
}
return ret;
}
diff --git a/core/src/main/java/com/yahoo/ycsb/measurements/Measurements.java b/core/src/main/java/com/yahoo/ycsb/measurements/Measurements.java
index 1bcd3938..fe1e9cc1 100644
--- a/core/src/main/java/com/yahoo/ycsb/measurements/Measurements.java
+++ b/core/src/main/java/com/yahoo/ycsb/measurements/Measurements.java
@@ -174,7 +174,7 @@ public class Measurements {
ThreadLocal<StartTimeHolder> tlIntendedStartTime = new ThreadLocal<Measurements.StartTimeHolder>() {
protected StartTimeHolder initialValue() {
return new StartTimeHolder();
- };
+ }
};
public void setIntendedStartTimeNs(long time) {
diff --git a/dynamodb/src/main/java/com/yahoo/ycsb/db/DynamoDBClient.java b/dynamodb/src/main/java/com/yahoo/ycsb/db/DynamoDBClient.java
index 8a9a8975..042a8e05 100644
--- a/dynamodb/src/main/java/com/yahoo/ycsb/db/DynamoDBClient.java
+++ b/dynamodb/src/main/java/com/yahoo/ycsb/db/DynamoDBClient.java
@@ -87,8 +87,6 @@ public class DynamoDBClient extends DB {
"An error occurred on the client.");
private static final String DEFAULT_HASH_KEY_VALUE = "YCSB_0";
- public DynamoDBClient() {}
-
/**
* Initialize any state for this DB. Called once per DB instance; there is
* one DB instance per client thread.
diff --git a/googledatastore/src/main/java/com/yahoo/ycsb/db/GoogleDatastoreClient.java b/googledatastore/src/main/java/com/yahoo/ycsb/db/GoogleDatastoreClient.java
index fb3a81ec..12fc0fac 100644
--- a/googledatastore/src/main/java/com/yahoo/ycsb/db/GoogleDatastoreClient.java
+++ b/googledatastore/src/main/java/com/yahoo/ycsb/db/GoogleDatastoreClient.java
@@ -83,8 +83,6 @@ public class GoogleDatastoreClient extends DB {
private Datastore datastore = null;
- public GoogleDatastoreClient() {}
-
/**
* Initialize any state for this DB. Called once per DB instance; there is
* one DB instance per client thread.
diff --git a/infinispan/src/main/java/com/yahoo/ycsb/db/InfinispanRemoteClient.java b/infinispan/src/main/java/com/yahoo/ycsb/db/InfinispanRemoteClient.java
index fb969e49..9b09f553 100644
--- a/infinispan/src/main/java/com/yahoo/ycsb/db/InfinispanRemoteClient.java
+++ b/infinispan/src/main/java/com/yahoo/ycsb/db/InfinispanRemoteClient.java
@@ -47,10 +47,6 @@ public class InfinispanRemoteClient extends DB {
private static final Log logger = LogFactory.getLog(InfinispanRemoteClient.class);
- public InfinispanRemoteClient() {
-
- }
-
@Override
public void init() throws DBException {
remoteIspnManager = RemoteCacheManagerHolder.getInstance(getProperties());
--
GitLab