From a6c71994e48bed0ab82dab3eaaa07f0b802c515e Mon Sep 17 00:00:00 2001 From: Sean Busbey <busbey@cloudera.com> Date: Tue, 26 Jan 2016 02:54:24 -0600 Subject: [PATCH] [checkstyle] consolidate checkstyle plugin configs. default to enforcing. - define checkstyle configs in as few places as possible - use checkstyle:check since it has defaults that match what we want (fail after logging to console) - modules that have current failures set property checkstyle.failOnViolation to false. --- accumulo/pom.xml | 24 +----------------------- aerospike/pom.xml | 26 +------------------------- binding-parent/pom.xml | 14 +++++++++++++- cassandra/pom.xml | 26 +------------------------- cassandra2/pom.xml | 26 +------------------------- checkstyle.xml | 4 ++-- core/pom.xml | 3 ++- couchbase/pom.xml | 6 +++++- dynamodb/pom.xml | 6 +++++- elasticsearch/pom.xml | 26 +------------------------- gemfire/pom.xml | 6 +++++- googledatastore/pom.xml | 27 ++------------------------- hbase098/pom.xml | 6 +++++- hbase10/pom.xml | 26 +------------------------- hypertable/pom.xml | 6 +++++- infinispan/pom.xml | 6 +++++- jdbc/pom.xml | 26 +------------------------- kudu/pom.xml | 26 +------------------------- memcached/pom.xml | 22 +--------------------- mongodb/pom.xml | 26 +------------------------- nosqldb/pom.xml | 26 +------------------------- orientdb/pom.xml | 24 ------------------------ pom.xml | 21 ++++++++++++++------- redis/pom.xml | 26 +------------------------- s3/pom.xml | 26 +------------------------- solr/pom.xml | 24 ------------------------ tarantool/pom.xml | 6 +++++- voldemort/pom.xml | 26 +------------------------- 28 files changed, 82 insertions(+), 435 deletions(-) diff --git a/accumulo/pom.xml b/accumulo/pom.xml index be8b9409..93faf584 100644 --- a/accumulo/pom.xml +++ b/accumulo/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2011 YCSB++ project, 2014 - 2015 YCSB contributors. +Copyright (c) 2011 YCSB++ project, 2014 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you @@ -70,28 +70,6 @@ LICENSE file. </dependency> </dependencies> <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> <testResources> <testResource> <directory>../workloads</directory> diff --git a/aerospike/pom.xml b/aerospike/pom.xml index 7487fb00..37cab3e2 100644 --- a/aerospike/pom.xml +++ b/aerospike/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -42,28 +42,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/binding-parent/pom.xml b/binding-parent/pom.xml index dde0827f..afb72d7b 100644 --- a/binding-parent/pom.xml +++ b/binding-parent/pom.xml @@ -1,5 +1,5 @@ <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -71,6 +71,18 @@ LICENSE file. </execution> </executions> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <executions> + <execution> + <id>validate</id> + <configuration> + <configLocation>../checkstyle.xml</configLocation> + </configuration> + </execution> + </executions> + </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-dependency-plugin</artifactId> diff --git a/cassandra/pom.xml b/cassandra/pom.xml index 7fd66c0f..ef4f20b4 100644 --- a/cassandra/pom.xml +++ b/cassandra/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -48,28 +48,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/cassandra2/pom.xml b/cassandra2/pom.xml index 8f3b743a..bbf4cd24 100644 --- a/cassandra2/pom.xml +++ b/cassandra2/pom.xml @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012-2015 YCSB contributors. All rights reserved. +Copyright (c) 2012-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -57,28 +57,4 @@ LICENSE file. <scope>test</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/checkstyle.xml b/checkstyle.xml index e18cb5b4..2197b022 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -180,7 +180,7 @@ LICENSE file. <property name="basicOffset" value="2" /> <property name="caseIndent" value="0" /> </module> - <module name="TodoComment"/> + <!-- <module name="TodoComment"/> --> <module name="UpperEll"/> </module> diff --git a/core/pom.xml b/core/pom.xml index 33fe500f..5e5da144 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -29,6 +29,7 @@ LICENSE file. <packaging>jar</packaging> <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> <jackson.api.version>1.9.4</jackson.api.version> </properties> diff --git a/couchbase/pom.xml b/couchbase/pom.xml index ff02debd..a7d231a7 100644 --- a/couchbase/pom.xml +++ b/couchbase/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -29,6 +29,10 @@ LICENSE file. <name>Couchbase Binding</name> <packaging>jar</packaging> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>couchbase</groupId> diff --git a/dynamodb/pom.xml b/dynamodb/pom.xml index bfe174c6..acde4cb0 100644 --- a/dynamodb/pom.xml +++ b/dynamodb/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -28,6 +28,10 @@ LICENSE file. <artifactId>dynamodb-binding</artifactId> <name>DynamoDB DB Binding</name> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>com.amazonaws</groupId> diff --git a/elasticsearch/pom.xml b/elasticsearch/pom.xml index da9975fc..49e3d96e 100644 --- a/elasticsearch/pom.xml +++ b/elasticsearch/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -57,28 +57,4 @@ LICENSE file. <scope>test</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/gemfire/pom.xml b/gemfire/pom.xml index 2dadf7ad..3aa417ee 100644 --- a/gemfire/pom.xml +++ b/gemfire/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -29,6 +29,10 @@ LICENSE file. <name>Gemfire DB Binding</name> <packaging>jar</packaging> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>com.gemstone.gemfire</groupId> diff --git a/googledatastore/pom.xml b/googledatastore/pom.xml index fd152428..4618a605 100644 --- a/googledatastore/pom.xml +++ b/googledatastore/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -28,6 +28,7 @@ LICENSE file. <artifactId>googledatastore-binding</artifactId> <name>Google Cloud Datastore Binding</name> <url>https://github.com/GoogleCloudPlatform/google-cloud-datastore</url> + <dependencies> <dependency> <groupId>com.google.apis</groupId> @@ -46,28 +47,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>false</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/hbase098/pom.xml b/hbase098/pom.xml index 5fa53085..465189ab 100644 --- a/hbase098/pom.xml +++ b/hbase098/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -28,6 +28,10 @@ LICENSE file. <artifactId>hbase098-binding</artifactId> <name>HBase 0.98.x DB Binding</name> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>org.apache.hbase</groupId> diff --git a/hbase10/pom.xml b/hbase10/pom.xml index 84a77384..c3e6cdc6 100644 --- a/hbase10/pom.xml +++ b/hbase10/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -53,28 +53,4 @@ LICENSE file. <scope>test</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/hypertable/pom.xml b/hypertable/pom.xml index 13ccd004..8c41f068 100644 --- a/hypertable/pom.xml +++ b/hypertable/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -29,6 +29,10 @@ LICENSE file. <name>Hypertable DB Binding</name> <packaging>jar</packaging> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>com.yahoo.ycsb</groupId> diff --git a/infinispan/pom.xml b/infinispan/pom.xml index efb81120..bb75caa1 100644 --- a/infinispan/pom.xml +++ b/infinispan/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -29,6 +29,10 @@ LICENSE file. <name>Infinispan DB Binding</name> <packaging>jar</packaging> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>org.infinispan</groupId> diff --git a/jdbc/pom.xml b/jdbc/pom.xml index 39588bf1..2c8337ba 100644 --- a/jdbc/pom.xml +++ b/jdbc/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -54,28 +54,4 @@ LICENSE file. <scope>test</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/kudu/pom.xml b/kudu/pom.xml index 3faa998c..8e2a8586 100644 --- a/kudu/pom.xml +++ b/kudu/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -42,30 +42,6 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> <repositories> <repository> <releases> diff --git a/memcached/pom.xml b/memcached/pom.xml index 2c0c375d..d1d002ea 100644 --- a/memcached/pom.xml +++ b/memcached/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2014-2015 YCSB contributors. All rights reserved. +Copyright (c) 2014-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -54,26 +54,6 @@ LICENSE file. <build> <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-assembly-plugin</artifactId> diff --git a/mongodb/pom.xml b/mongodb/pom.xml index cc5a283c..25a6f4ee 100644 --- a/mongodb/pom.xml +++ b/mongodb/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -61,30 +61,6 @@ LICENSE file. <scope>test</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> <repositories> <repository> <releases> diff --git a/nosqldb/pom.xml b/nosqldb/pom.xml index 8be31796..434301fd 100644 --- a/nosqldb/pom.xml +++ b/nosqldb/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -42,28 +42,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/orientdb/pom.xml b/orientdb/pom.xml index 407f75a7..79c38873 100644 --- a/orientdb/pom.xml +++ b/orientdb/pom.xml @@ -59,28 +59,4 @@ LICENSE file. <version>1.7.10</version> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/pom.xml b/pom.xml index 73af18a4..190c30ba 100644 --- a/pom.xml +++ b/pom.xml @@ -130,6 +130,15 @@ LICENSE file. </modules> <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <version>2.15</version> + </plugin> + </plugins> + </pluginManagement> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> @@ -143,18 +152,16 @@ LICENSE file. <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>checkstyle.xml</configLocation> - </configuration> <executions> <execution> - <id>validate</id> + <id>validate</id> <phase>validate</phase> <goals> - <goal>checkstyle</goal> + <goal>check</goal> </goals> + <configuration> + <configLocation>checkstyle.xml</configLocation> + </configuration> </execution> </executions> </plugin> diff --git a/redis/pom.xml b/redis/pom.xml index 6e0b2278..957b4b91 100644 --- a/redis/pom.xml +++ b/redis/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -42,28 +42,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/s3/pom.xml b/s3/pom.xml index 2bc53df9..8623a019 100644 --- a/s3/pom.xml +++ b/s3/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -41,28 +41,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> -<build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/solr/pom.xml b/solr/pom.xml index dd713854..d25a140b 100644 --- a/solr/pom.xml +++ b/solr/pom.xml @@ -56,28 +56,4 @@ LICENSE file. <scope>test</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> diff --git a/tarantool/pom.xml b/tarantool/pom.xml index 85f0fe62..11f01419 100644 --- a/tarantool/pom.xml +++ b/tarantool/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2015 YCSB contributors. All rights reserved. +Copyright (c) 2015-2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -30,6 +30,10 @@ LICENSE file. <name>Tarantool DB Binding</name> <packaging>jar</packaging> + <properties> + <checkstyle.failOnViolation>false</checkstyle.failOnViolation> + </properties> + <dependencies> <dependency> <groupId>org.tarantool</groupId> diff --git a/voldemort/pom.xml b/voldemort/pom.xml index f4b21396..943888e7 100644 --- a/voldemort/pom.xml +++ b/voldemort/pom.xml @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <!-- -Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. +Copyright (c) 2012 - 2016 YCSB contributors. All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You @@ -48,28 +48,4 @@ LICENSE file. <scope>provided</scope> </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.15</version> - <configuration> - <consoleOutput>true</consoleOutput> - <configLocation>../checkstyle.xml</configLocation> - <failOnViolation>true</failOnViolation> - <failsOnError>true</failsOnError> - </configuration> - <executions> - <execution> - <id>validate</id> - <phase>validate</phase> - <goals> - <goal>checkstyle</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> </project> -- GitLab